Skip to content

Return correct index/value id in radar/polarArea #6581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 19, 2019
Merged

Return correct index/value id in radar/polarArea #6581

merged 1 commit into from
Oct 19, 2019

Conversation

@kurkle
Copy link
Member

@kurkle kurkle commented Oct 19, 2019

Override both _getIndexScaleId and _getValueScaleId in radar / polarArea

  • Default implementation returns x/y axis id, but radar / polarArea use options.scale.

Extracted from #6576 to ease reviewing

@etimberg etimberg merged commit feaf418 into chartjs:master Oct 19, 2019
@snyk-bot snyk-bot mentioned this pull request Nov 9, 2019
Merged
@kurkle kurkle deleted the index/value-scale-support-for-radar-and-polarArea branch November 13, 2019 06:12
This was referenced Mar 4, 2020
Open
Open
@vpetersson vpetersson mentioned this pull request Mar 7, 2020
Merged
This was referenced Mar 9, 2020
Closed
Merged
@snyk-bot snyk-bot mentioned this pull request Apr 1, 2020
Open
This was referenced Apr 14, 2020
Open
Open
exwm pushed a commit to exwm/Chart.js that referenced this pull request Apr 30, 2021
@kurkle @etimberg
Return correct index/value id in radar/polarArea (chartjs#6581)
535b9ba
This was referenced Jun 1, 2021
Closed
Merged
Closed
Open
Closed
Open
Open
This was referenced Jul 5, 2021
Closed
Open
This was referenced Jul 27, 2021
Closed
Merged
Merged
This was referenced Oct 14, 2021
Merged
Closed
@jw jw mentioned this pull request Jan 17, 2022
Open
1 task
This was referenced Jan 21, 2022
Merged
Closed
This was referenced Feb 4, 2022
Closed
Closed
This was referenced Mar 7, 2022
Open
Open
Open
Merged
1 task
This was referenced Nov 29, 2022
Closed
Closed
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@etimberg etimberg etimberg approved these changes

+1 more reviewer

@benmccann benmccann benmccann approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kurkle @benmccann @etimberg