Support object values for bar charts #6323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmccann
reviewed
Jun 7, 2019
Contributor
benmccann
left a comment
benmccann
left a comment
There was a problem hiding this comment.
lgtm. just one small comment
Contributor
Author
|
I also refactored the entire category scale code. It is reduced by 154 bytes. |
benmccann
reviewed
Jun 8, 2019
benmccann
reviewed
Jun 11, 2019
benmccann
previously approved these changes
Jun 12, 2019
kurkle
reviewed
Jun 12, 2019
benmccann
approved these changes
Jun 12, 2019
kurkle
approved these changes
Jun 18, 2019
etimberg
approved these changes
Jun 18, 2019
etimberg
approved these changes
Jun 19, 2019
This was referenced Mar 4, 2020
This was referenced Mar 9, 2020
This was referenced Apr 14, 2020
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
* Support object values for bar charts * Check if null or undefined * Refactor category scale code * Make isNullOrUndef global
This was referenced Jun 1, 2021
Open
This was referenced Jul 5, 2021
This was referenced Jul 27, 2021
This was referenced Oct 14, 2021
1 task
This was referenced Jan 21, 2022
This was referenced Feb 4, 2022
This was referenced Mar 7, 2022
Open
1 task
This was referenced Nov 29, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves the following problems:
{x, y}) for category scales, but if the label is a falsy value such as0and'', that point is not correctly handled.getPixelForValuedoesn't acceptdatasetIndexto handle object values for the ruler in bar charts.Note that bars for the same label won't be stacked even if the stack options are enabled because the current implementation only supports index-based stacking, not label-based stacking. That is not the scope of this PR. So, a bar will simply overlay the other bars with the same label.
Master: https://jsfiddle.net/nagix/yhzsgnae/
This PR: https://jsfiddle.net/nagix/zpcou3Lh/
The motivation of this PR is to support this type of 'column range chart' as well as gantt chart. I will open another PR to add support for object values for floating bars.