fix(docs): correct config file paths in README#427
Open
clarabennettdev wants to merge 1 commit intocharmbracelet:mainfrom
Open
fix(docs): correct config file paths in README#427clarabennettdev wants to merge 1 commit intocharmbracelet:mainfrom
clarabennettdev wants to merge 1 commit intocharmbracelet:mainfrom
Conversation
The README listed user config dir paths as: [[user config dir]]/wishlist/config.yaml [[user config dir]]/wishlist/config.yml [[user config dir]]/wishlist/config But the actual code in cmd/wishlist/main.go uses: [[user config dir]]/wishlist.yaml [[user config dir]]/wishlist.yml [[user config dir]]/wishlist This matches the output of 'wishlist --help'. Fixes charmbracelet#410
clarabennettdev
requested review from
aymanbagabas and
meowgorithm
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The README listed user config dir paths with a
wishlist/subdirectory:But the actual code in
cmd/wishlist/main.go(userConfigPaths()) places config files directly in the user config dir:This also matches the output of
wishlist --help.Fixes #410