feat(tui): reduce animations #1250
Conversation
Signed-off-by: Carlos Alexandro Becker <[email protected]>
Signed-off-by: Carlos Alexandro Becker <[email protected]>
Signed-off-by: Carlos Alexandro Becker <[email protected]>
caarlos0
requested review from
andreynering and
aymanbagabas
and removed request for
a team
internal/config/config.go
Outdated
| CompactMode bool `json:"compact_mode,omitempty" jsonschema:"description=Enable compact mode for the TUI interface,default=false"` | ||
| DiffMode string `json:"diff_mode,omitempty" jsonschema:"description=Diff mode for the TUI interface,enum=unified,enum=split"` | ||
| ReduceAnimations bool `json:"reduce_animations,omitempty" jsonschema:"description=Reduce animations in the TUI,default=false"` |
There was a problem hiding this comment.
We should eventually consider documenting these on the README. All of them are missing currently.
Maybe this is a good time to do it.
| func (s *noAnim) SetLabel(label string) { | ||
| s.rendered = lipgloss.NewStyle(). | ||
| Foreground(s.Color). | ||
| Render(cmp.Or(label, "Working") + ellipsisFrames[2]) |
There was a problem hiding this comment.
I think showing just a white Working... is a bit too boring. I wonder if we can improve it somehow. Perhaps add a colorful meaningful character as a prefix, at least to make it distinct from the actual text.
This is probably a job for @meowgorithm 🙂
There was a problem hiding this comment.
Agreed—I can come up with some stuff.
Signed-off-by: Carlos Alexandro Becker <[email protected]>
Signed-off-by: Carlos Alexandro Becker <[email protected]>
There was a problem hiding this comment.
Let's update the README to expose the config + what do you think about adding an environment variable as well @caarlos0 and @andreynering (or is SSH_TTY enough)?
I'll also come up with some options for "Working…".
internal/tui/components/anim/anim.go
Outdated
| // If the FPS is 20 (50 milliseconds) this means that the ellipsis will | ||
| // change every 8 frames (400 milliseconds). | ||
| ellipsisAnimSpeed = 8 | ||
| ellipsisanimSpeed = 8 |
There was a problem hiding this comment.
Looks like you mistakenly reverted a rename here.
|
No strong opinion on the env. It should be simple to add, so why not? Not sure on the name:
|
Signed-off-by: Carlos Alexandro Becker <[email protected]>
Signed-off-by: Carlos Alexandro Becker <[email protected]>
|
@meowgorithm done |
Signed-off-by: Carlos Alexandro Becker <[email protected]>
This allows to disable the spinner completely.
Instead, it'll show a static text while working, and then disappear.
closes #908
closes #1147