Skip to content

Conversation

@caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Oct 9, 2025

needs #1208

CleanShot.2025-10-09.at.23.20.18.mp4

Signed-off-by: Carlos Alexandro Becker <[email protected]>
Signed-off-by: Carlos Alexandro Becker <[email protected]>
Signed-off-by: Carlos Alexandro Becker <[email protected]>
Signed-off-by: Carlos Alexandro Becker <[email protected]>
@caarlos0 caarlos0 self-assigned this Oct 9, 2025
@caarlos0 caarlos0 requested a review from a team as a code owner October 9, 2025 16:54
@caarlos0 caarlos0 requested review from andreynering and tauraamui and removed request for a team October 9, 2025 16:54
@caarlos0 caarlos0 marked this pull request as draft October 9, 2025 16:54
Signed-off-by: Carlos Alexandro Becker <[email protected]>
Signed-off-by: Carlos Alexandro Becker <[email protected]>
Signed-off-by: Carlos Alexandro Becker <[email protected]>
Signed-off-by: Carlos Alexandro Becker <[email protected]>
Signed-off-by: Carlos Alexandro Becker <[email protected]>
Signed-off-by: Carlos Alexandro Becker <[email protected]>
Signed-off-by: Carlos Alexandro Becker <[email protected]>
Signed-off-by: Carlos Alexandro Becker <[email protected]>
Signed-off-by: Carlos Alexandro Becker <[email protected]>
Signed-off-by: Carlos Alexandro Becker <[email protected]>
Signed-off-by: Carlos Alexandro Becker <[email protected]>
Signed-off-by: Carlos Alexandro Becker <[email protected]>
Signed-off-by: Carlos Alexandro Becker <[email protected]>
Signed-off-by: Carlos Alexandro Becker <[email protected]>
Signed-off-by: Carlos Alexandro Becker <[email protected]>
Signed-off-by: Carlos Alexandro Becker <[email protected]>
Signed-off-by: Carlos Alexandro Becker <[email protected]>
Signed-off-by: Carlos Alexandro Becker <[email protected]>
Signed-off-by: Carlos Alexandro Becker <[email protected]>
@caarlos0 caarlos0 marked this pull request as ready for review October 10, 2025 02:21
Base automatically changed from mcp to main October 10, 2025 13:07
Signed-off-by: Carlos Alexandro Becker <[email protected]>
- ESC now works
- better handling of size events
- properly set input's width
- generic arguments input that will be used in #1209 (in fact this is
  extracted from #1209)
- improved code a bit

Signed-off-by: Carlos Alexandro Becker <[email protected]>
@kujtimiihoxha
Copy link
Member

@caarlos0 this needs a rebase/merge .

@tauraamui
Copy link
Contributor

tauraamui commented Oct 16, 2025

@caarlos0 this needs a rebase/merge .

I've resolved the conflicts on Carlos' behalf, if they're somehow wrong or mistaken etc., then I'll revert. Hmm looks like CI has failed 😅

@caarlos0
Copy link
Member Author

caarlos0 commented Oct 16, 2025

this needs #1213 first

will do it all here so its easier to get it merged

@LarsArtmann
Copy link

@caarlos0 back to merge conflicts, but the PR seems nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants