feat: light theme #1200
Draft
feat: light theme #1200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the Contributor License Agreement (CLA) and hereby sign the CLA. |
Added structured Markdown color support with theme-based customization: - Added MarkdownColors and ChromaColors structs to Theme - Added helper functions for color fallback and hex conversion - Updated NewCharmtoneTheme() with comprehensive Markdown colors - Updated NewCharmtoneLightTheme() with appropriate light theme colors - Refactored buildStyles() to use theme colors with fallbacks Also adjusted the FgMuted color in the light theme to make model name and execution time text more readable. Reordered the foreground color progression to be more logical: - FgMuted: charmtone.Iron (medium gray) - FgHalfMuted: charmtone.BBQ (dark) - FgSubtle: charmtone.Charcoal (medium dark) This enables proper theme adaptation for Markdown content, ensuring consistent visual presentation when switching between dark and light themes. 💘 Generated with Crush Co-Authored-By: Crush <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CONTRIBUTING.md.Relates: #755
I gave a try at vibecoding this features. But as i said in the issue i'm not competent enough to review it properly. So feel free to take over it.
In its current state it works,
but since markdown colors are hardcoded it cannot be changed by the theme, and the text contrast is not right(edit: vibefixed).Here are some screenshots (the asciinema record did not kept the colors...):
