feat: refactor providers and improve system prompt #1171
Merged
+19,957
−9,182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kujtimiihoxha
force-pushed
the
crush-fantasy
branch
from
4a557db to
d786161
Compare
kujtimiihoxha
force-pushed
the
crush-fantasy
branch
from
d9d9fd5 to
c58a4d4
Compare
andreynering
reviewed
Oct 2, 2025
There was a problem hiding this comment.
I gave this some testing, and it is pretty good overall!
I didn't review all the code because it's a lot, but looks much cleaner and more organized than before.
Below I added a couple of bugs I found when using the OpenAI compatible providers (OpenRouter and Hyper) specifically. Those bugs are not present for OpenAI or Anthropic.
- The machine stops after every tool call, and I have to keep typing
continue. Despite of this, after everycontinueit's able to proceed.
Screenshot
- Frequent errors on
ViewandEdittools.old_string not found in fileandInvalid view parameterskeeps happening even after many attempts.
Screenshot
kujtimiihoxha
force-pushed
the
crush-fantasy
branch
from
a604c3c to
ad881b2
Compare
kujtimiihoxha
force-pushed
the
crush-fantasy
branch
from
ad881b2 to
b45dcfe
Compare
kujtimiihoxha
force-pushed
the
crush-fantasy
branch
from
835fbc1 to
5d42049
Compare
This was referenced Oct 27, 2025
Signed-off-by: Carlos Alexandro Becker <[email protected]>
andreynering
approved these changes
Oct 27, 2025
This was referenced Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactor for provider-model durability and a general boost in LLM performance increase across the board.
Some breaking changes:
typetoopenai-compatfromopenaigeminitype is nowgoogle