Skip to content

support auto completion #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ti-chi-bot merged 8 commits into from
Mar 23, 2022
Merged

support auto completion #139

ti-chi-bot merged 8 commits into from
Mar 23, 2022

Conversation

@Hexilee
Copy link
Member

@Hexilee Hexilee commented Mar 15, 2022

  • support global static completion
  • support dynamic completion for UID of recover subcommand

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 15, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Andrewmatilde
  • WangXiangUSTC

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested review from STRRL and fewdan March 15, 2022 11:14
sonatype-lift[bot]
sonatype-lift bot reviewed Mar 15, 2022
View reviewed changes
sonatype-lift[bot]
sonatype-lift bot reviewed Mar 15, 2022
View reviewed changes
sonatype-lift[bot]
sonatype-lift bot reviewed Mar 15, 2022
View reviewed changes
sonatype-lift[bot]
sonatype-lift bot reviewed Mar 15, 2022
View reviewed changes
sonatype-lift[bot]
sonatype-lift bot reviewed Mar 15, 2022
View reviewed changes
Hexilee added 3 commits March 15, 2022 19:48
@Hexilee
handle errors
9cb1a59 
Signed-off-by: xixi <[email protected]>
@Hexilee
bump cobra to 1.4.0
e0da300 
Signed-off-by: xixi <[email protected]>
@Hexilee
go mod tidy
2c86856 
Signed-off-by: xixi <[email protected]>
@ti-chi-bot ti-chi-bot added size/XL and removed size/L labels Mar 17, 2022
WangXiangUSTC
WangXiangUSTC reviewed Mar 18, 2022
View reviewed changes
Copy link
Collaborator

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM, this feature is so cool!

@Hexilee
resolve comments
8078c77 
Signed-off-by: xixi <[email protected]>
@WangXiangUSTC
Copy link
Collaborator

WangXiangUSTC commented Mar 22, 2022

LGTM

@WangXiangUSTC
Copy link
Collaborator

WangXiangUSTC commented Mar 22, 2022

@Andrewmatilde PTAL

Andrewmatilde
Andrewmatilde approved these changes Mar 23, 2022
View reviewed changes
Copy link
Member

@Andrewmatilde Andrewmatilde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great job！

Andrewmatilde
Andrewmatilde approved these changes Mar 23, 2022
View reviewed changes
Copy link
Member

@Andrewmatilde Andrewmatilde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great job！

@WangXiangUSTC
Copy link
Collaborator

WangXiangUSTC commented Mar 23, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 23, 2022

@WangXiangUSTC: /merge in this pull request requires 2 approval(s).

Details

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@WangXiangUSTC
Copy link
Collaborator

WangXiangUSTC commented Mar 23, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 23, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 8078c77

@ti-chi-bot ti-chi-bot merged commit d93fc1f into chaos-mesh:main Mar 23, 2022
@cwen0 cwen0 mentioned this pull request Jul 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WangXiangUSTC WangXiangUSTC WangXiangUSTC approved these changes

@Andrewmatilde Andrewmatilde Andrewmatilde approved these changes

@fewdan fewdan Awaiting requested review from fewdan

@STRRL STRRL Awaiting requested review from STRRL

+1 more reviewer

@sonatype-lift sonatype-lift[bot] sonatype-lift[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/XL status/can-merge status/LGT2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Hexilee @ti-chi-bot @WangXiangUSTC @Andrewmatilde