Skip to content

Conversation

@WangXiangUSTC
Copy link
Collaborator

@WangXiangUSTC WangXiangUSTC commented Dec 20, 2021

Signed-off-by: xiang [email protected]

  1. fix issue error.api.internal_server_error: strconv.ParseFloat: parsing \"\": invalid syntax #116

    The reason is that the correlation is "", and parse float failed. Set default value for it in this pr

  2. fix partition, it is deleted by mistake in network attack: support bandwidth limit #91 😢

TODO: add test for them

Signed-off-by: xiang <[email protected]>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 20, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Andrewmatilde
  • iguoyr

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@WangXiangUSTC WangXiangUSTC changed the title Network: set default value for duplicate action Network: set default value for duplicate and corrupt action Dec 20, 2021
Signed-off-by: xiang <[email protected]>
@WangXiangUSTC WangXiangUSTC changed the title Network: set default value for duplicate and corrupt action Network: set default value for duplicate and corrupt action && fix partition Dec 20, 2021
@WangXiangUSTC WangXiangUSTC added the bug Something isn't working label Dec 20, 2021
Copy link
Member

@Andrewmatilde Andrewmatilde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@iguoyr iguoyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iguoyr
Copy link
Member

iguoyr commented Dec 22, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 4c52ed1

@ti-chi-bot ti-chi-bot merged commit 7103539 into main Dec 22, 2021
@cwen0 cwen0 deleted the fix_duplicate branch December 30, 2021 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants