-
Notifications
You must be signed in to change notification settings - Fork 54
Icon update PR made by bezier-asset main #2728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 3a79512 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
개요Bezier 아이콘 패키지의 마이너 버전을 업데이트하여 차트 및 경로 편집 관련 아이콘을 추가하고, 기존 차트 아이콘을 수정하며, 중복된 intersect.svg를 삭제합니다. 변경 사항
예상 검토 노력🎯 1 (Trivial) | ⏱️ ~2분
관련 PR 목록
축하 시
Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2728 +/- ##
=======================================
Coverage 79.33% 79.33%
=======================================
Files 146 146
Lines 2913 2913
Branches 932 932
=======================================
Hits 2311 2311
+ Misses 598 567 -31
- Partials 4 35 +31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.changeset/icon-update-1764303366516.md (1)
5-5: 변경로그 설명을 더 자세하게 작성하는 것을 권장합니다.현재 "Update icons"는 매우 간결합니다. 추가되는 차트 관련 아이콘들(combo-chart)이나 패스파인더 기능(pathfinder) 등에 대한 더 자세한 설명을 포함하면 사용자가 변경사항을 더 쉽게 이해할 수 있습니다. 예: "차트 및 경로 도구 아이콘 추가"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (10)
packages/bezier-icons/icons/area-chart.svgis excluded by!**/*.svgpackages/bezier-icons/icons/combo-chart.svgis excluded by!**/*.svgpackages/bezier-icons/icons/intersect.svgis excluded by!**/*.svgpackages/bezier-icons/icons/line-chart.svgis excluded by!**/*.svgpackages/bezier-icons/icons/page-add.svgis excluded by!**/*.svgpackages/bezier-icons/icons/pathfinder-exclude.svgis excluded by!**/*.svgpackages/bezier-icons/icons/pathfinder-intersect.svgis excluded by!**/*.svgpackages/bezier-icons/icons/pathfinder-subtract-left.svgis excluded by!**/*.svgpackages/bezier-icons/icons/pathfinder-subtract-right.svgis excluded by!**/*.svgpackages/bezier-icons/icons/pathfinder-union.svgis excluded by!**/*.svg
📒 Files selected for processing (1)
.changeset/icon-update-1764303366516.md(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Chromatic
🔇 Additional comments (1)
.changeset/icon-update-1764303366516.md (1)
1-24: 변경집합 파일이 올바르게 구성되었습니다.이 변경집합 파일은 형식이 유효하고 모든 아이콘 변경사항이 정확하게 문서화되어 있습니다. 마이너 버전 범프는 새로운 아이콘 추가 및 기존 아이콘 수정에 적절합니다.
Chromatic Report🚀 Congratulations! Your build was successful! |
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @channel.io/[email protected] ### Minor Changes - Update icons ([#2728](#2728)) by @wes5510 Modified - area-chart.svg - line-chart.svg Added - combo-chart.svg - page-add.svg - pathfinder-exclude.svg - pathfinder-intersect.svg - pathfinder-subtract-left.svg - pathfinder-subtract-right.svg - pathfinder-union.svg Deleted - intersect.svg ## [email protected] ### Patch Changes - Updated dependencies - @channel.io/[email protected] <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## 릴리스 노트 * **새로운 기능** * 콤보 차트, 페이지 추가, 경로찾기 관련 아이콘 7개 추가 * 차트 아이콘 업데이트 * **변경 사항** * 기존 아이콘 제거 및 개선 * 아이콘 라이브러리 버전 0.52.0으로 업데이트 <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> <!-- end of auto-generated comment: release notes by coderabbit.ai --> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Icon update is ready to be merged! 🎉
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.