feat: Add NewContent into RoomMessageEvent#15
Closed
diamondburned wants to merge 1 commit intochanbakjsd:masterfrom
Closed
feat: Add NewContent into RoomMessageEvent#15diamondburned wants to merge 1 commit intochanbakjsd:masterfrom
diamondburned wants to merge 1 commit intochanbakjsd:masterfrom
Conversation
This commit adds the NewContent field into RoomMessageEvent. It is
supposed to be an object with the same type as RoomMessageEvent and
usually contains the message information that will replace the old
event's body.
For reference, here's an example JSON:
{
"content": {
"body": " * b",
"m.new_content": {
"body": "b",
"msgtype": "m.text"
},
"m.relates_to": {
"event_id": "$eventID",
"rel_type": "m.replace"
},
"msgtype": "m.text"
}
}
Owner
|
I think the comment above on I am not sure what the best way to do this is but there should also be a way for the user to access RelType. |
Contributor
Author
|
On second thought, since the user is manually adding the Closing this PR because of that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds the NewContent field into RoomMessageEvent. It is
supposed to be an object with the same type as RoomMessageEvent and
usually contains the message information that will replace the old
event's body.
For reference, here's an example JSON:
{ "content": { "body": " * b", "m.new_content": { "body": "b", "msgtype": "m.text" }, "m.relates_to": { "event_id": "$eventID", "rel_type": "m.replace" }, "msgtype": "m.text" } }