Skip to content

Conversation

@nikparo
Copy link
Contributor

@nikparo nikparo commented Sep 9, 2025

Closes #

📝 Description

Add a brief description

I found the e2e testing suite very flaky while exploring lit wrapper support. The root issue was mainly that the tests were not waiting for new rendered elements to appear. For me pnpm e2e-react now runs consistently without failures. I still see the occasional flakiness when the page doesn't render at all (less than 0.5%), but not sure how to combat that.

I have not tested this against the e2e testing suites other than react since they don't seem maintained(?) and have a lot of failures on main.

⛳️ Current behavior (updates)

Please describe the current behavior that you are modifying

The e2e tests often don't wait for elements to become visible or receive focus before trying to interact (fire off keyboard events etc), resulting in race conditions and flakiness.

🚀 New behavior

Please describe the behavior or changes this PR adds

e2e tests wait for the elements to become visible, receive focus etc. before continuing to interact with the component.

💣 Is this a breaking change (Yes/No):

No

📝 Additional Information

@changeset-bot
Copy link

changeset-bot bot commented Sep 9, 2025

⚠️ No Changeset found

Latest commit: 9fdc77d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Sep 9, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
zag-nextjs Ready Ready Preview Sep 9, 2025 8:20am
zag-solid Ready Ready Preview Sep 9, 2025 8:20am
zag-svelte Ready Ready Preview Sep 9, 2025 8:20am
zag-vue Ready Ready Preview Sep 9, 2025 8:20am
zag-website Ready Ready Preview Sep 9, 2025 8:20am

@segunadebayo segunadebayo merged commit 743dd4a into chakra-ui:main Sep 9, 2025
5 checks passed
@nikparo nikparo deleted the test/e2e-flakiness-fixes branch September 16, 2025 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants