-
-
Notifications
You must be signed in to change notification settings - Fork 233
fix(e2e): race condition fixes #2694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(e2e): race condition fixes #2694
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Closes #
📝 Description
I found the e2e testing suite very flaky while exploring lit wrapper support. The root issue was mainly that the tests were not waiting for new rendered elements to appear. For me
pnpm e2e-reactnow runs consistently without failures. I still see the occasional flakiness when the page doesn't render at all (less than 0.5%), but not sure how to combat that.I have not tested this against the e2e testing suites other than
reactsince they don't seem maintained(?) and have a lot of failures onmain.⛳️ Current behavior (updates)
The e2e tests often don't wait for elements to become visible or receive focus before trying to interact (fire off keyboard events etc), resulting in race conditions and flakiness.
🚀 New behavior
e2e tests wait for the elements to become visible, receive focus etc. before continuing to interact with the component.
💣 Is this a breaking change (Yes/No):
No
📝 Additional Information