Skip to content

Allow dead_letter_policy params to be optional #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tcnghia merged 1 commit into from
Feb 4, 2024
Merged

Allow dead_letter_policy params to be optional #116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/cloudevent-trigger/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ No requirements.
| Name | Description | Type | Default | Required |
|------|-------------|------|---------|:--------:|
| <a name="input_broker"></a> [broker](#input\_broker) | The name of the pubsub topic we are using as a broker. | `string` | n/a | yes |
| <a name="input_dead_letter_policy"></a> [dead\_letter\_policy](#input\_dead\_letter\_policy) | The dead letter policy for the subscription. | <pre>object({<br> dead_letter_topic = string<br> max_delivery_attempts = number<br> })</pre> | <pre>{<br> "dead_letter_topic": null,<br> "max_delivery_attempts": 3<br>}</pre> | no |
| <a name="input_dead_letter_policy"></a> [dead\_letter\_policy](#input\_dead\_letter\_policy) | The dead letter policy for the subscription. | <pre>object({<br> dead_letter_topic = optional(string, null)<br> max_delivery_attempts = optional(number, 3)<br> })</pre> | <pre>{<br> "dead_letter_topic": null,<br> "max_delivery_attempts": 3<br>}</pre> | no |
| <a name="input_filter"></a> [filter](#input\_filter) | A Knative Trigger-style filter over the cloud event attributes. | `map(string)` | n/a | yes |
| <a name="input_name"></a> [name](#input\_name) | n/a | `string` | n/a | yes |
| <a name="input_private-service"></a> [private-service](#input\_private-service) | The private cloud run service that is subscribing to these events. | <pre>object({<br> name = string<br> region = string<br> })</pre> | n/a | yes |
Expand Down
4 changes: 2 additions & 2 deletions modules/cloudevent-trigger/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ variable "private-service" {
variable "dead_letter_policy" {
description = "The dead letter policy for the subscription."
type = object({
dead_letter_topic = string
max_delivery_attempts = number
dead_letter_topic = optional(string, null)
max_delivery_attempts = optional(number, 3)
})
default = {
dead_letter_topic = null
Expand Down