Skip to content

Bad comments in chai.js (and elsewhere) #1425

@elibarzilay

Description

@elibarzilay

Looks like #451 switched many docstring comments from /** to /*! -- where the latter are comments that are not dropped by minifies / bundlers / etc, and are mainly intended for copyright notices. As a result, having chai included in a bundle that esbuild generates has a whole bunch of useless comments at the end (see below). Shouldn't these non-copyright comments use /**?

... all code ...
...
/*!
 * Module dependencies.
 */
/*!
 * Module export.
 */
...

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions