feat(types): Add typescript definitions#221
Merged
keithamus merged 1 commit intochaijs:masterfrom Aug 28, 2018
Merged
Conversation
austince
force-pushed
the
feat/type-defs
branch
from
a44b889 to
a0ca1bc
Compare
austince
force-pushed
the
feat/type-defs
branch
from
a0ca1bc to
8e59507
Compare
keithamus
approved these changes
Aug 20, 2018
Member
keithamus
left a comment
keithamus
left a comment
There was a problem hiding this comment.
This LGTM 👍. Does anyone from @chaijs/chai-http or anyone else who uses typescript want to chime in with a 👍 or 👎?
Member
|
Very nice! 👏 I'll longer have to install LGTM 👍 |
JamesMessinger
approved these changes
Aug 21, 2018
Contributor
Author
|
@keithamus do you have any time to merge this and then I'll make a release PR? |
Member
|
👍 also @austince if you'd like I can add you as a collaborator. As a collaborator I would ask you don't merge your own PRs, but you would be able to lead the direction of the code a lot more! |
Contributor
Author
|
Thanks @keithamus, I would be honored to be a collaborator and would still tread lightly! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #209
Based off of: https://github.com/DefinitelyTyped/DefinitelyTyped/tree/ffbf9da05fd9fe404a250586b15b7a3276bfe7cc/types/chai-http
Cleaned up the
@typesones a bit and added the type definitions in the distribution. Doesn't seem like@typeshas a def for superagent@3.7.0 -- maybe we should upgrade superagent to3.8.3, both for maintenance and to align with@types?