Skip to content

Conversation

@koji-1009
Copy link

@koji-1009 koji-1009 commented Nov 4, 2025

fix #2457

Description

Implements timeout handling for NativeAdapter. Previously, Dio's timeout options (sendTimeout, connectTimeout, receiveTimeout) were ignored when using NativeAdapter.

This PR adds proper timeout features in ConversionLayerAdapter, following the same approach as io_adapter.dart.

Note: Due to http package limitations, connectTimeout and receiveTimeout are combined for the response phase.

New Pull Request Checklist

  • I have read the Documentation
  • I have searched for a similar pull request in the project and found none
  • I have updated this branch with the latest main branch to avoid conflicts (via merge from master or rebase)
  • I have added the required tests to prove the fix/feature I'm adding
  • I have updated the documentation (if necessary)
  • I have run the tests without failures
  • I have updated the CHANGELOG.md in the corresponding package

Additional context and info (if any)

@koji-1009 koji-1009 requested a review from a team as a code owner November 4, 2025 11:46
@koji-1009 koji-1009 force-pushed the feat/timeout_native_adapter branch from cf0f7d6 to fdcda84 Compare November 4, 2025 11:53
@koji-1009 koji-1009 marked this pull request as draft November 4, 2025 12:00
@koji-1009 koji-1009 force-pushed the feat/timeout_native_adapter branch from fdcda84 to bc6c463 Compare November 4, 2025 12:14
@koji-1009 koji-1009 marked this pull request as ready for review November 4, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[native_dio_adapter] NativeAdapter ignores timeout options (sendTimeout, connectTimeout, receiveTimeout)

1 participant