-
Notifications
You must be signed in to change notification settings - Fork 189
Various fixes to acceptance tests and ci scripts #5944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craigcomstock
commented
Nov 13, 2025
00447e3 to
7dbbe23
Compare
nickanderson
approved these changes
Nov 13, 2025
Member
nickanderson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM some suggestions you can leave behind if you want. Overall looks like a nice update.
Ticket: ENT-7541 Changelog: none
Ticket: none Changelog: none
Username is "Super User" and not the expected "root" Ticket: ENT-13016 Changelog: none
c952231 to
a4eb201
Compare
The test expecs root, bin, daemon as first three groups. On SuSE 15 this is not the case. They have root, shadow, trusted. Ticket: ENT-13504 Changelog: none
Ticket: none Changelog: none
Ticket: none Changelog: none
… now passes Ticket: none Changelog: none
Ticket: ENT-13505 Changelog: none
On RedHat 10 the cipher AES128-GCM-SHA256 is not part of the -ciphersuites TLSv1.3 defaults and so the client with defaults cannot communicate with the server. We need to configure these tests more dynamically based on what ciphers are available in the openssl that is being used. In this case RedHat 10 uses systemssl and happens to be openssl 3.2.2 which apparently breaks this test. Ticket: ENT-13494 Changelog: none (cherry picked from commit 647aae6) (cherry picked from commit 5a62129)
Ticket: none Changelog: none
a4eb201 to
93a47de
Compare
The test expecs root, bin, daemon - in that order. However, on aix it is root, daemon, bin. Ticket: ENT-13504 Signed-off-by: Lars Erik Wik <[email protected]>
Contributor
|
I'm stealing this one in #5947, feel free to close :) |
Contributor
Author
|
thank you @larsewi. excellent work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
together
cfengine/masterfiles#3074
#5944