Skip to content

Conversation

@cfahlgren1
Copy link
Owner

This will enable us to make schema changes and track more things like #41 and also not break existing DuckDB databases when upgrading observers.

  • Track OpenAI Arguments (top_p, temperature, etc)

image

@davidberenstein1957
Copy link
Collaborator

@cfahlgren1 is this ready to be reviewed?

@cfahlgren1 cfahlgren1 marked this pull request as ready for review January 29, 2025 18:02
@cfahlgren1
Copy link
Owner Author

@cfahlgren1 is this ready to be reviewed?

Should be very close, will do another pass. I noticed messages wasn't being stored in DuckDB for some reason. But should be fixed here. Will do another pass in the next day or two.

Couple small changes:

  • Use DuckDB Store by default (if no store is provided)
  • Updated openai example to just use gpt-4o (reduces a few requirements to text the initial example: 1. getting hf fine grained token, etc)
  • We can run migrations, so it should be backwards compatible with older
  • We store arguments like stream, temperature, etc in arguments field.

@cfahlgren1 cfahlgren1 merged commit d72ec97 into main Feb 18, 2025
9 checks passed
@cfahlgren1 cfahlgren1 deleted the cfahlgren1/improve-duckdb-store branch February 18, 2025 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants