Open
Conversation
lemunozm
reviewed
May 27, 2024
wischli
reviewed
Jun 4, 2024
wischli
left a comment
wischli
left a comment
There was a problem hiding this comment.
Not sure if your eyes have already caught these two divergences from the recommended XCM configuration with the Polkadot SDK message queue refactor. If not, hope they will help us fixing the message issues.
lemunozm
reviewed
Jun 6, 2024
Contributor
lemunozm
left a comment
lemunozm
left a comment
There was a problem hiding this comment.
Seeing all those workspace dependencies is a big pleasure to my eyes ❤️
Comment on lines
+61
to
+63
| ## Currently only needed to make cumulus-relay-chain-inprocess-interface compile, not sure why cumulus works though | ||
| polkadot-cli = { git = "https://github.com/paritytech/polkadot-sdk", branch = "release-polkadot-v1.7.2" } | ||
| polkadot-runtime-common = { git = "https://github.com/paritytech/polkadot-sdk", default-features = false, branch = "release-polkadot-v1.7.2" } |
Contributor
There was a problem hiding this comment.
Is it due to some macro? Sometimes macros force you to include extra dependencies to unroll correctly on the user side.
Contributor
Author
There was a problem hiding this comment.
No, the fudge-test-runtime is using it.
cdamian
commented
Jun 6, 2024
| pub struct MessageQueueWeightInfo; | ||
|
|
||
| // As of this version, the current implementation of WeightInfo for (), has weights that are bigger than 0. | ||
| impl pallet_message_queue::WeightInfo for MessageQueueWeightInfo { |
Contributor
Author
There was a problem hiding this comment.
Having this helps us avoid future failures due to new weights.
toolchain: Use stable rust
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update polkadot dependencies to
v1.7.2.