Skip to content
This repository was archived by the owner on Dec 23, 2023. It is now read-only.

Conversation

@elharo
Copy link
Contributor

@elharo elharo commented Mar 17, 2020

@elharo elharo requested review from a team, dinooliva, rghetia and songy23 as code owners March 17, 2020 11:02
@elharo
Copy link
Contributor Author

elharo commented Mar 17, 2020

Looks like deprecations have been made errors:

Task :opencensus-contrib-appengine-standard-util:compileJava

/home/travis/build/census-instrumentation/opencensus-java/contrib/appengine_standard_util/gen_gradle/src/main/java/io/opencensus/contrib/appengine/standard/util/TraceProto.java:37: warning: [deprecation] InternalDescriptorAssigner in FileDescriptor has been deprecated

com.google.protobuf.Descriptors.FileDescriptor.InternalDescriptorAssigner assigner =

                                              ^

/home/travis/build/census-instrumentation/opencensus-java/contrib/appengine_standard_util/gen_gradle/src/main/java/io/opencensus/contrib/appengine/standard/util/TraceProto.java:38: warning: [deprecation] InternalDescriptorAssigner in FileDescriptor has been deprecated

    new com.google.protobuf.Descriptors.FileDescriptor.    InternalDescriptorAssigner() {

                                                      ^

/home/travis/build/census-instrumentation/opencensus-java/contrib/appengine_standard_util/gen_gradle/src/main/java/io/opencensus/contrib/appengine/standard/util/TraceProto.java:46: warning: [deprecation] internalBuildGeneratedFileFrom(String[],FileDescriptor[],InternalDescriptorAssigner) in FileDescriptor has been deprecated

  .internalBuildGeneratedFileFrom(descriptorData,

  ^

error: warnings found and -Werror specified

@codecov-io
Copy link

codecov-io commented Mar 17, 2020

Codecov Report

Merging #2024 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2024      +/-   ##
============================================
- Coverage     83.09%   83.06%   -0.03%     
  Complexity     2251     2251              
============================================
  Files           319      319              
  Lines         10529    10529              
  Branches       1048     1048              
============================================
- Hits           8749     8746       -3     
- Misses         1441     1446       +5     
+ Partials        339      337       -2     
Impacted Files Coverage Δ Complexity Δ
...census/implcore/trace/export/SpanExporterImpl.java 93.28% <0.00%> (-2.24%) 12.00% <0.00%> (ø%)
...re/trace/export/InProcessSampledSpanStoreImpl.java 95.26% <0.00%> (-1.19%) 21.00% <0.00%> (-1.00%)
...pencensus/implcore/trace/RecordEventsSpanImpl.java 93.36% <0.00%> (+1.02%) 50.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0c9230...0821aae. Read the comment docs.

@elharo elharo changed the title deps: update protobuf and gRPC deps: update gRPC Mar 17, 2020
findBugsJsr305Version = '3.0.2'
errorProneVersion = '2.3.2'
grpcVersion = '1.25.0'
grpcVersion = '1.27.2'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

upgrading to grpcVersion will break grpc metrics collection using opencensus unless grpc-census package is included. See this release-note.

Please update the change.log for the dependency change and link to grpc release-note in the change.log.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@rghetia rghetia merged commit 093c5f5 into census-instrumentation:master Mar 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants