Skip to content
This repository was archived by the owner on Dec 23, 2023. It is now read-only.

Conversation

@elharo
Copy link
Contributor

@elharo elharo commented Mar 11, 2020

@elharo elharo requested review from a team, dinooliva, rghetia and songy23 as code owners March 11, 2020 22:58
@elharo
Copy link
Contributor Author

elharo commented Mar 11, 2020

Not sure if this is a flaky failure or not. Only one of the build nodes complained.

+python buildscripts/check-git-history.py

Pull request contains a merge commit:

  • 3542d9c Merge remote-tracking branch 'upstream/master'

|\

| * 700199c (origin/master, origin/HEAD, master) update guava (#2018)

| * 4a33e1d chore(RELEASING.md): update list of VERSION_FILES (#2019)

| * d2367b0 feat: Allow users to register the same Meter multiple times without exception (#2017)

  • | 6fc6193 docs: 1.0 no longer expected

|/

@mayurkale22
Copy link
Member

Not sure if this is a flaky failure or not. Only one of the build nodes complained.

+python buildscripts/check-git-history.py

Pull request contains a merge commit:

  • 3542d9c Merge remote-tracking branch 'upstream/master'

|\

| * 700199c (origin/master, origin/HEAD, master) update guava (#2018)

| * 4a33e1d chore(RELEASING.md): update list of VERSION_FILES (#2019)

| * d2367b0 feat: Allow users to register the same Meter multiple times without exception (#2017)

  • | 6fc6193 docs: 1.0 no longer expected

|/

Build is failing due to merge commit, try removing it from this pull request.

@codecov-io
Copy link

Codecov Report

Merging #2020 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2020      +/-   ##
============================================
+ Coverage     83.09%   83.11%   +0.01%     
- Complexity     2251     2252       +1     
============================================
  Files           319      319              
  Lines         10529    10529              
  Branches       1048     1048              
============================================
+ Hits           8749     8751       +2     
+ Misses         1441     1440       -1     
+ Partials        339      338       -1
Impacted Files Coverage Δ Complexity Δ
...pencensus/implcore/trace/RecordEventsSpanImpl.java 93.36% <0%> (+1.02%) 50% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 700199c...a683bc9. Read the comment docs.

@elharo elharo closed this Mar 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants