F-Droid delivers pre-release builds as stable

[PhilLab]

Several users report that F-Droid auto updated their Rethink app and breaking their setup, because it already deployed the recent pre-releases: https://gitlab.com/fdroid/fdroiddata/-/issues/3608

In the comments, it was mentioned:

We use git only, not Github proprietary features.
The simplest way is... name the tags accordingly.
Eg. 0.5-beta1

Is there anything we could do in the repo here? Or must we change the update toolchain of F-Droid instead?

[ignoramous]

The F-Droid launch process Rethink uses isn't the greatest, but we are stuck with it.

there anything we could do in the repo here

I wouldn't know, tbh. I only know that F-Droid picks up code against tags and builds apk on their servers. If marking -beta will fix it, then we'll keep that in mind, but I would need to know for sure, because there's nothing in our build process that I see which will treat -beta any differently.

change the update toolchain of F-Droid instead

Marking a tag as "pre-release" is changeable, which means, making changes to F-Droid to look at it only when the code is being built ... will result in situations where, a tag is marked "pre-release" after F-Droid kicks off its build cycle (or a tag is unmarked after F-Droid has). Even with that limitation, if F-Droid upstream receptive of it, the change could be made to check the "pre-release" status.

[mdosch]

Would be awesome if a new release could be tagged that contains the latest stable status. Currently rethink dns constantly crashes when opening the GUI. The notification claims I am protected but I realized Google keyboard has Internet access although I didn't allow that. I just switched last weekend to a new phone and as it has upstream support I didn't install lineage is and also didn't root it. So I started using rethink dns instead of afwall just a few days ago and since yesterday it's doing badly. 😥

[ignoramous]

Currently rethink dns constantly crashes when opening the GUI.

Which version are you on? The footer of the "About" UI shows version information.

If you're technical enough, can you grab adb logcat output from when Rethink crashes? Also, is there a pattern or does Rethink crash in the background? If it crashes while in the background, it could be a network engine crash, and the "Bug report" in "About" UI should have captured those. You can either either analyse the zip file it creates with "tombstones" (which have network engine crashes) yourself, or share them with us over email, if you're comfortable doing so (please do mention this GitHub issue in the subject).

[mdosch]

I'm on the fdroid version this issue is about:

Version v0.5.5t (519)

I can't open the app as it constantly crashes, when I open it. I'll try to grab some logcat output. Can you name the email address I shall send it to?

[mdosch]

Ok, there is nothing private to see when I try to open rethink and it crashes:

adb logcat|grep rethink
09-03 20:03:12.914  4146  4197 I GoLog   : I go_intramain.go:2543>bootstrap.go:80>bootstrap.go:192: dns: default: DNS-over-HTTPS reinit https://zero.rethinkdns.com/dns-query zero.rethinkdns.com w/ 104.21.83.62,172.67.214.246,2606:4700:3030::6815:533e,2606:4700:3030::ac43:d6f6
09-03 20:03:12.915  4146  4197 I GoLog   : I _cgo_gotypes.go:10925>go_intramain.go:2543>bootstrap.go:85: dns: default: DNS-over-HTTPS new https://zero.rethinkdns.com/dns-query zero.rethindns.com 104.21.83.62,172.67.214.246,2606:4700:3030::6815:533e,2606:4700:3030::ac43:d6f6
09-03 20:03:12.922  4146  4263 I GoLog   : I doh.go:115>doh.go:181>transport.go:1207: dns: protected Bootstrap! zero.rethinkdns.com => [104.21.83.62 172.67.214.246 2606:4700:3030::6815:533e 2606:4700:3030::ac43:d6f6]
09-03 20:03:12.922  4146  4263 I GoLog   : I doh.go:115>doh.go:181>transport.go:1216: dns: reg regular/protected done Bootstrap! zero.rethinkdns.com[+[104.21.83.62 172.67.214.246 2606:4700:3030::6815:533e 2606:4700:3030::ac43:d6f6]] => [104.21.83.62 2606:4700:3030::6815:533e 2606:4700:3030::ac43:d6f6 172.67.214.246]
09-03 20:03:12.922  4146  4263 I GoLog   : I bootstrap.go:110>doh.go:115>doh.go:245: doh: new transport(DNS-over-HTTPS): https://zero.rethinkdns.com/dns-query; relay? false; addrs? [104.21.83.62 172.67.214.246 2606:4700:3030::6815:533e 2606:4700:3030::ac43:d6f6]; resolved? true, ech? false
09-03 20:03:12.922  4146  4263 I GoLog   : I tunnel.go:175>bootstrap.go:209>bootstrap.go:252: dns: default: start; DNS-over-HTTPS with zero.rethinkdns.com[rethink.zero.rethinkdns.com]; ok? true
09-03 20:03:12.922  4146  4263 I GoLog   : I tunnel.go:182>transport.go:213>cacher.go:143: cache: (CacheDefault) setup: cached.rethink.zero.rethinkdns.com; opts: ttl=10m0s; bumps=10; size=256
09-03 20:03:12.922  4146  4263 I GoLog   : I tun2socks.go:76>tunnel.go:182>transport.go:223: dns: new! gw? true; default? rethink.zero.rethinkdns.com

I wonder why it tries DoH while I have set it up to connect to my DoT as this is faster than DoH…

[ignoramous]

Ok, there is nothing private to see when I try to open rethink and it crashes:

There are no crashes in the log output you shared. That's likely because you're grepping on the string "rethink" (which is unlikely to capture the stacktrace, if any).

You could instead grep -iE "(golog|e go)" to capture logs from just the network engine (assuming the crash is in the network engine and not the UI layer).

[mdosch]

You could instead grep -iE "(golog|e go)" to capture logs from just the network engine (assuming the crash is in the network engine and not the UI layer).

Sure:

09-03 21:13:27.921 11741 11796 I GoLog   : I go_intramain.go:2543>bootstrap.go:80>bootstrap.go:192: dns: default: DNS-over-HTTPS reinit https://zero.rethinkdns.com/dns-query zero.rethinkdns.com w/ 104.21.83.62,172.67.214.246,2606:4700:3030::6815:533e,2606:4700:3030::ac43:d6f6
09-03 21:13:27.921 11741 11796 I GoLog   : I _cgo_gotypes.go:10925>go_intramain.go:2543>bootstrap.go:85: dns: default: DNS-over-HTTPS new https://zero.rethinkdns.com/dns-query zero.rethinkdns.com 104.21.83.62,172.67.214.246,2606:4700:3030::6815:533e,2606:4700:3030::ac43:d6f6
09-03 21:13:27.921 11741 11796 I GoLog   : I tun2socks.go:76>tunnel.go:166>natpt.go:51: natpt: new; mode(2)
09-03 21:13:27.921 11741 11796 I GoLog   : I tun2socks.go:76>tunnel.go:167>proxies.go:327: proxy: new
09-03 21:13:27.924 11741 11797 I GoLog   : W bootstrap.go:110>doh.go:115>doh.go:134>proxies.go:713: proxy: for: Bootstrap; not found
09-03 21:13:27.925 11741 11797 I GoLog   : I doh.go:115>doh.go:181>transport.go:1207: dns: protected Bootstrap! zero.rethinkdns.com => [104.21.83.62 172.67.214.246 2606:4700:3030::6815:533e 2606:4700:3030::ac43:d6f6]
09-03 21:13:27.925 11741 11797 I GoLog   : I doh.go:115>doh.go:181>transport.go:1216: dns: reg regular/protected done Bootstrap! zero.rethinkdns.com[+[104.21.83.62 172.67.214.246 2606:4700:3030::6815:533e 2606:4700:3030::ac43:d6f6]] => [104.21.83.62 172.67.214.246 2606:4700:3030::6815:533e 2606:4700:3030::ac43:d6f6]
09-03 21:13:27.925 11741 11797 I GoLog   : I bootstrap.go:110>doh.go:115>doh.go:245: doh: new transport(DNS-over-HTTPS): https://zero.rethinkdns.com/dns-query; relay? false; addrs? [104.21.83.62 172.67.214.246 2606:4700:3030::6815:533e 2606:4700:3030::ac43:d6f6]; resolved? true, ech? false
09-03 21:13:27.927 11741 11806 I GoLog   : I async.go:58>dns64.go:76>dns64.go:265: dns64: ipv4only.arpa w underlying network resolver
09-03 21:13:27.927 11741 11806 I GoLog   : I dns64.go:286>dns64.go:330>dns64.go:368: dns64: add ipnet [64:ff9b:1:fffe::/96] for server(__local464)
09-03 21:13:27.927 11741 11806 I GoLog   : W async.go:58>dns64.go:79: dns64: err reg underlay(lookup ipv4only.arpa.: no such host) / local(<nil>)
09-03 21:13:27.940 11741 11804 I GoLog   : I tunnel.go:175>bootstrap.go:209>bootstrap.go:252: dns: default: start; DNS-over-HTTPS with zero.rethinkdns.com[rethink.zero.rethinkdns.com]; ok? true
09-03 21:13:27.941 11741 11807 I GoLog   : I tunnel.go:182>transport.go:207>alg.go:632: alg: setup done
09-03 21:13:27.941 11741 11804 I GoLog   : I tunnel.go:182>transport.go:213>cacher.go:143: cache: (CacheDefault) setup: cached.rethink.zero.rethinkdns.com; opts: ttl=10m0s; bumps=10; size=256
09-03 21:13:27.941 11741 11804 I GoLog   : I tun2socks.go:76>tunnel.go:182>transport.go:223: dns: new! gw? true; default? rethink.zero.rethinkdns.com
09-03 21:13:27.941 11741 11804 I GoLog   : I tunnel.go:183>dns.go:94>goos.go:71: dns53: goosr: setup done
09-03 21:13:27.942 11741 11804 I GoLog   : I tunnel.go:183>transport.go:321>cacher.go:143: cache: (CacheGoos) setup: cached.localhost:53; opts: ttl=10m0s; bumps=10; size=256
09-03 21:13:27.942 11741 11804 I GoLog   : I tun2socks.go:76>tunnel.go:183>transport.go:335: dns: add transport Goos@localhost:53; caching? true
09-03 21:13:27.945 11741 11804 I GoLog   : I tunnel.go:184>dns.go:99>grounded.go:36: grounded(BlockAll) setup: 127.0.0.3:53
09-03 21:13:27.945 11741 11804 I GoLog   : I tunnel.go:184>transport.go:321>cacher.go:143: cache: (CacheBlockAll) setup: cached.127.0.0.3:53; opts: ttl=10m0s; bumps=10; size=256
09-03 21:13:27.945 11741 11804 I GoLog   : I tun2socks.go:76>tunnel.go:184>transport.go:335: dns: add transport BlockAll@127.0.0.3:53; caching? true
09-03 21:13:27.945 11741 11804 I GoLog   : I tunnel.go:185>dns.go:103>errorer.go:36: errorer(Fixed) setup: 127.3.3.3:33
09-03 21:13:27.945 11741 11804 I GoLog   : I tunnel.go:185>transport.go:321>cacher.go:143: cache: (CacheFixed) setup: cached.127.3.3.3:33; opts: ttl=10m0s; bumps=10; size=256
09-03 21:13:27.945 11741 11804 I GoLog   : I tun2socks.go:76>tunnel.go:185>transport.go:335: dns: add transport Fixed@127.3.3.3:33; caching? true
09-03 21:13:27.945 11741 11804 I GoLog   : I tunnel.go:186>dns.go:107>plus.go:73: plus: at plus.[fdaa:9125::9125:9]:53; added: 0/0
09-03 21:13:27.945 11741 11804 I GoLog   : I tunnel.go:186>transport.go:321>cacher.go:143: cache: (CachePlus) setup: cached.plus.[fdaa:9125::9125:9]:53; opts: ttl=10m0s; bumps=10; size=256
09-03 21:13:27.945 11741 11804 I GoLog   : I tun2socks.go:76>tunnel.go:186>transport.go:335: dns: add transport Plus@plus.[fdaa:9125::9125:9]:53; caching? true
09-03 21:13:27.945 11741 11804 I GoLog   : I tunnel.go:187>transport.go:321>cacher.go:143: cache: (CacheDcProxy) setup: cached.; opts: ttl=10m0s; bumps=10; size=256
09-03 21:13:27.945 11741 11804 I GoLog   : I tun2socks.go:76>tunnel.go:187>transport.go:335: dns: add transport DcProxy@; caching? true
09-03 21:13:27.945 11741 11804 I GoLog   : I tunnel.go:188>dns.go:116>mdns.go:81: mdns: setup: 46
09-03 21:13:27.945 11741 11804 I GoLog   : I tunnel.go:188>transport.go:321>cacher.go:143: cache: (Cachemdns) setup: cached.224.0.0.251:5353; opts: ttl=10m0s; bumps=10; size=256
09-03 21:13:27.945 11741 11804 I GoLog   : I tun2socks.go:76>tunnel.go:188>transport.go:335: dns: add transport mdns@224.0.0.251:5353; caching? true
09-03 21:13:27.945 11741 11804 I GoLog   : I tun2socks.go:76>tunnel.go:192>link.go:60: dialers: ips: protos set to 46; diff? false
09-03 21:13:27.945 11741 11804 I GoLog   : I dns.go:28>ipmapper.go:68>ips.go:117: dialers: ips: mapper ok? true
09-03 21:13:27.945 11741 11804 I GoLog   : I ipmapper.go:68>ips.go:119>ipmap.go:184: ipmap: new resolver; ok? true
09-03 21:13:27.945 11741 11804 I GoLog   : I dns.go:28>ipmapper.go:69>link.go:60: dialers: ips: protos set to 46; diff? false
09-03 21:13:27.945 11741 11804 I GoLog   : I tun2socks.go:76>tunnel.go:195>tcp.go:85: tcp: new handler created
09-03 21:13:27.945 11741 11804 I GoLog   : I tun2socks.go:76>tunnel.go:196>udp.go:92: udp: new handler created
09-03 21:13:27.945 11741 11804 I GoLog   : I tun2socks.go:76>tunnel.go:197>icmp.go:38: icmp: new handler created
09-03 21:13:27.945 11741 11804 I GoLog   : I sink.go:41>sink.go:108>seamless.go:115: netstack: pcap stdout(false): done?(false)
09-03 21:13:27.945 11741 11804 I GoLog   : I sink.go:42>sink.go:112>seamless.go:125: netstack: pcap file(false): done?(false)
09-03 21:13:27.945 11741 11804 I GoLog   : I multiserver.go:481: dnscrypt: refreshRoutes: remove all relays
09-03 21:13:27.945 11741 11804 I GoLog   : I multiserver.go:493: dnscrypt: refreshRoutes: 0/0 for 0 servers
09-03 21:13:27.945 11741 11804 I GoLog   : I tunnel.go:202>tunnel.go:178>netstack.go:243: netstack: new stack4 and stack6
09-03 21:13:27.945 11741 11804 I GoLog   : W seamless.go:99>fdbased.go:212>fdbased.go:300>fds.go:143: ns: dispatch: fds: stop: no-op
09-03 21:13:27.945 11741 11804 I GoLog   : I fdbased.go:301>fdbased.go:222>dispatchers.go:195: ns: dispatch: newReadVDispatcher: tun(148)
09-03 21:13:27.945 11741 11804 I GoLog   : E tunnel.go:202>tunnel.go:180>seamless.go:99>fdbased.go:212>fdbased.go:314: ns: tun(-1): (-1 => 148) swap: no dispatcher? true for new fd; err <nil>
09-03 21:13:27.945 11741 11804 I GoLog   : I tunnel.go:180>seamless.go:106>seamless.go:86: netstack: new endpoint(fd:148 / mtu:1500); err? <nil>
09-03 21:13:27.945 11741 11804 I GoLog   : I tunnel.go:202>tunnel.go:191>netstack.go:215: netstack: route(ask:46; set: 46); done
09-03 21:13:27.945 11741 11804 I GoLog   : I tunnel.go:202>tunnel.go:193>netstack.go:42: netstack: 148: new nic? true; remove nic? err(unknown nic id)
09-03 21:13:27.945 11741 11804 I GoLog   : I nic.go:221>seamless.go:263>fdbased.go:357: ns: tun(148): attach: new dispatcher & looper
09-03 21:13:27.945 11741 11804 I GoLog   : I stack.go:934>nic.go:221>seamless.go:266: netstack: magic: attach dispatcher? false
09-03 21:13:27.945 11741 11804 I GoLog   : I tunnel.go:193>netstack.go:77>netstack.go:175: netstack: 1 ifaddrs 4(10.111.222.1/24) 6(fd66:f83a:c650::1/120)
09-03 21:13:27.945 11741 11804 I GoLog   : I tunnel.go:202>tunnel.go:193>netstack.go:105: netstack: 148: up(1)! new? true; addrs: 10.111.222.1/24 fd66:f83a:c650::1/

[ignoramous]

Thanks. The logs you share don't indicate any crash. In fact, they look perfectly alright, and don't point to any malfunction let alone a crash.

Makes me thing if the crash is in the UI layer, which you can capture with adb logcat --pid=$(adb shell pidof -s com.celzero.bravedns), but may result in too many logs.

I know this back and forth is a bit tedious and so we'll bring in optional automatic crash reporting in v055u.

[mdosch]

Now that's weird, when I opened rethink dns today after receiving your reply it just opens normally without crashing. I could activate it and now everything works as expected. :-/

[ignoramous]

I'll reopen if someone can confirm if -beta is enough for F-Droid to ignore the tags.

I wouldn't know, tbh. I only know that F-Droid picks up code against tags and builds apk on their servers. If marking -beta will fix it, then we'll keep that in mind, but I would need to know for sure, because there's nothing in our build process that I see which will treat -beta any differently.

I am closing the issue until then as there's not going to be any more changes from our end on how we tag releases, otherwise. Plus, there simply isn't enough time nor is it priority to change the F-Droid build process for Rethink. Welcome pull requests though.

[shuvashish76]

I'll reopen if someone can confirm if -beta is enough for F-Droid to ignore the tags.

Ping @linsui

[linsui]

F-Droid can exclude -beta tags, or whatever can be excluded with a regex. Just set the UpdateCheckMode accordingly to Tags <regex> to only pick matching tags.