Support client_name connection parameter for redis transport#2367
Conversation
54e2489 to
3c91c85
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the client_name connection parameter in the Redis transport, allowing Redis clients to be identified with a custom name. This is the first step toward enabling client name configuration through Celery configuration.
- Adds
client_nameas a configurable transport option for Redis connections - Updates connection parameter handling to include the client name in Redis connection pools
- Adds comprehensive test coverage for both regular Redis connections and Sentinel configurations
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| kombu/transport/redis.py | Adds client_name attribute and includes it in connection parameters |
| t/unit/transport/test_redis.py | Adds tests for client_name parameter handling in regular and Sentinel Redis connections |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
auvipy
left a comment
There was a problem hiding this comment.
would like to have more reference for this, can you share?
Same 🙏 |
3c91c85 to
c14851a
Compare
|
Absolutely! Feel free to ask any question you'd like 💪 |
|
On another note, @Nusnus watch out that you force pushed some changes that are not relevant to my PR. |
auvipy
left a comment
There was a problem hiding this comment.
may be we also need to update the docs to highlight the change
…github-mdalp.com:mdalp/kombu into support-client-name-connection-parameter-for-redis
auvipy
left a comment
There was a problem hiding this comment.
can we get better example docs where users can check the example to use in their code?
|
Hi @auvipy , I'm a bit lost, where do you suggest I should document that? |
This is the first step to allow passing the client name from the celery configuration.
I'll send a PR when I can to do that.