Revert "Feature: urllib3 instead of curl"

[auvipy]

Reverts #2134 to fix the performance regression related to #2258

[codecov]

Codecov Report

❌ Patch coverage is 61.16505% with 80 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.06%. Comparing base (67588f8) to head (fcf3f3d).
⚠️ Report is 21 commits behind head on main.

Files with missing lines	Patch %	Lines
kombu/asynchronous/http/curl.py	60.00%	63 Missing and 15 partials ⚠️
kombu/asynchronous/http/__init__.py	77.77%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2261      +/-   ##
==========================================
- Coverage   81.54%   81.06%   -0.48%     
==========================================
  Files          77       77              
  Lines        9546     9632      +86     
  Branches     1163     1180      +17     
==========================================
+ Hits         7784     7808      +24     
- Misses       1570     1621      +51     
- Partials      192      203      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Nusnus]

Please add a description and link to the issue that triggered this revert so it will be easier to track in the future. Thank you!

[auvipy]

updated the related issue

[auvipy]

i think we should revert this change for now

[Nusnus]

i think we should revert this change for now

This change is done across celery, kombu and pytest-celery.
I want to manage this revert op carefully, as we’re deep into the release cycle.

Just merging this will make main incompatible with celery and pytest-celery main.

[auvipy]

No problem take your time. Sorry if my comments seems pushy, all the open pr are meant to be a supporting hand only.

[auvipy]

I think we can merge this to revert

[Nusnus]

I think we can merge this to revert

We might want to wait for another patch release before, probably this week.

Let me give you an update soon.

P.S
We also need to properly communicate this revert in the release notes for v5.6

[auvipy]

Sure no prob. Maybe one or 2 MORE patch versions

[Nusnus]

Sure no prob. Maybe one or 2 MORE patch versions

You were reading my mind bro, awesome 💯

[auvipy]

after this is merged, we should also look into #2300 and the other pr where some improvements are suggested

[auvipy]

as we are done with 5.5.4 release in kombu and celery 5.5.3, I think we can merged this PR to get the ball running for v5.6.... we got some important related pr for SQS pending. and we already past the timeline of may 30.

addressed