feat: update logging and settings configuration with infra services#1032
Merged
feat: update logging and settings configuration with infra services#1032
Conversation
sylviamclaughlin
approved these changes
Jan 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
This pull request refactors the initialization logic in
app/main.pyto improve configuration and logging setup. The most important changes are grouped below:Configuration and Logging Refactor:
core.configandcore.loggingwith new imports frominfrastructure.servicesandinfrastructure.logging.setup, indicating a shift to infrastructure-based configuration and logging.get_module_logger()withconfigure_logging(settings=settings), explicitly configuring logging viastructlogusing the settings object.load_dotenv()withget_settings(), showing a move away from environment variable loading to a settings service.