Conversation
giantcow
added
the
do-not-merge
giantcow
reviewed
Dec 9, 2025
Contributor
giantcow
left a comment
giantcow
left a comment
There was a problem hiding this comment.
Not sure why the auto-queue task is failing... there's not a lot of context in the logs
https://github.com/cdklabs/cdk-monitoring-constructs/pull/686/checks#step:2:131
cdklabs-automation
pushed a commit
that referenced
this pull request
Dec 10, 2025
This is extracted from #686 and an incremental step towards upgrading to JSII@5.x. This introduces new types to replace the usage of the generic type that needs to be removed since JSII@5.x doesn't support generics as part of constructs' APIs. This does kind of spam new interfaces into the API, but I think that's an acceptable trade-off (the alternative is just removing this aspect, or moving it to a TS-only library). `MonitoringAspectType` would be removed as part of a later breaking change. --- _By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license_ --------- Co-authored-by: arkon <arkon@users.noreply.github.com> Co-authored-by: Caymon / Kayo <24500457+giantcow@users.noreply.github.com>
Contributor
|
@Mergifyio rebase |
Contributor
☑️ Nothing to do, the required conditions are not metDetails
|
arkon
force-pushed
the
jsii5
branch
2 times, most recently
from
2820c9a to
446ffa9
Compare
This removes some APIs/types that had replacements added previously in order to avoid using generics and tuples, which JSII@5 does not support. The BaseMetricFactory might affect other extensions of that abstract class outside of this library, which would need to be confirmed by reviewers. This does not address Rosetta doc errors, which are still disabled.
Contributor
Author
|
This is still pending validation that it doesn't impact the internal library (in a totally unaddressable way) that extends this one (by linking locally and doing something like I can't help with that given I don't work at Amazon anymore, but not that anyone with access can help validate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes some APIs/types that had replacements added previously in order to avoid using generics and tuples, which JSII@5 does not support.
The BaseMetricFactory might affect other extensions of that abstract class outside of this library, which would need to be confirmed by reviewers.
This does not address Rosetta doc errors, which are still disabled.
This also just uses the default JSII version that Projen currently specifies, which despite being documented as
~5.8.0gives~5.7.Given this is technically breaking changes to some APIs, this should include a major version update if merged (and grouped with other breaking changes, if any).
Fixes #633
Related docs:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license