Directly create specific event types #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify the SDK user experience by exposing methods to create directly specific events, rather then having a single method that creates events by type and requires type assertions to access event specific attributes. I preserved the factory method that creates the events by type for now as it's convenient for testing all the various events in one unit test. Signed-off-by: Andrea Frittoli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the SDK user experience by exposing methods to create
directly specific events, rather then having a single method
that creates events by type and requires type assertions to
access event specific attributes.
I preserved the factory method that creates the events by type
for now as it's convenient for testing all the various events
in one unit test.
Signed-off-by: Andrea Frittoli [email protected]
/cc @xibz