Handle event versions in the SDK #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change CDEventType to be a struct to allow for one-time parsing of the type string. The event type is still stored as string in the context so that it may unmarshal without the need for a custom unmarshaller. When producing events, the SDK produces the latest version of an event, the only one know to the SDK. When consuming events, the SDK allows for versions different from the SDK ones, as long as they are compatible with the SDK one, according to the versioning rules from the spec. The spec submodule has been moved into pkg/api so that we may use go embed to embed the schemas from the spec into the event modules which allows to embed the schema definitions in the SDK module. Signed-off-by: Andrea Frittoli <[email protected]>
afrittoli
force-pushed
the
handle_versions
branch
2 times, most recently
from
d851b73 to
7863790
Compare
Signed-off-by: Andrea Frittoli <[email protected]>
afrittoli
force-pushed
the
handle_versions
branch
from
7863790 to
eb104f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change CDEventType to be a struct to allow for one-time parsing of the type string. The event type is still stored as string in the context so that it may unmarshal without the need for a custom unmarshaller.
When producing events, the SDK produces the latest version of an event, the only one know to the SDK.
When consuming events, the SDK allows for versions different from the SDK ones, as long as they are compatible with the SDK one, according to the versioning rules from the spec.
The spec submodule has been moved into pkg/api so that we may use go embed to embed the schemas from the spec into the event modules which allows to embed the schema definitions in the SDK module.