Packetizing fixture, attaching to host simulation#37
Merged
Conversation
Owner
cceckman
commented
Mar 29, 2025
cceckman
commented
- Program when running the programming program
- More tests for host side
- Document erratum on end flag
- Demo, by simulation on host
``` ∵ curl -v0 localhost:3278/counts * Trying 127.0.0.1:3278... * Connected to localhost (127.0.0.1) port 3278 (#0) > GET /counts HTTP/1.0 > Host: localhost:3278 > User-Agent: curl/7.88.1 > Accept: */* > * HTTP 1.0, assume close after body < HTTP/1.0 200 OK < Host: Fomu < Content-Type: text/plain; charset=utf-8 < 👍 * Closing connection 0 requests: 0001 ok_responses: 0001 error_responses: 0000 ```
slongfield
approved these changes
Mar 30, 2025
| want_bytes = 1 | ||
| # Input is done, in theory | ||
| p3 = Packet(flags=Flag.END, stream_id=1, body=bytes()) | ||
| self.send(p3.to_bytes()) |
Collaborator
There was a problem hiding this comment.
This seems to be the cause of the issue where we can't send more than one request. If I get rid of this line, I can get as many /coffee (418) and /counts responses I want from curl
Owner
Author
There was a problem hiding this comment.
The rewrite/split of "separate state machines" also fixed the "only one request", without getting rid of this -- and I think the "stop" is important to capture, so I'd like to leave this.
Merging this with the bug intact, #39 has the rewrite.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.