Merged
Conversation
lilyjge
approved these changes
Feb 24, 2026
lilyjge
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly agentic coding, both vLLM inference modes are tested via demos, no impact on Gemini and GPT rankers.
I will add tests for sglang and tensorrt in a follow up PR if we decide to keep them.
Before this change we would create the prompts for all requests, then process the sliding window for all requests in parallel. This meant every single request had to complete the ranking of the current window before sending the next batch. For thinking models, only a single harder query is enough to keep everyone waiting, lots of idle time.
This cl does the prompt creation, llm inference, permutation update and enqueing of the next window for each request individually, the batch_size controls the number of on the fly requests to vllm inference handlers.
Pull Request Checklist
Reference Issue
Please provide the reference to issue this PR is addressing (# followed by the issue number). If there is no associated issue, write "N/A".
ref:
Checklist Items
Before submitting your pull request, please review these items:
PR Type
What kind of change does this PR introduce?