Parse floats correctly and fix mistake from go-yaml/yaml#171 #483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The regular expression is copy & pasted form the one in the spec. The change suggested in go-yaml/yaml#171 and integrated was improper. Closes go-yaml/yaml#290 (cherry-pick of go-yaml/yaml@7b8349a) Signed-off-by: John Ryan <[email protected]>
Closed
Contributor
|
@jtigger lets add a test in yamlmeta/parser_test.go to avoid accidentally regressing on this bug. |
cppforlife
reviewed
Sep 9, 2021
pivotaljohn
force-pushed
the
fix-floats
branch
from
12bc4be to
7699046
Compare
pivotaljohn
pushed a commit
that referenced
this pull request
Oct 7, 2021
- this file was recently updated in a bug fix on parsing float values. as a result what _was_ a string is now a float literal (see #483) - `go fmt` uses lowercase 'e' for the exponent notation - various tooling applies `go fmt` to our code while building and releasing. - we've updated our build and test scripts to skip this package (see prior commits). - Go Releaser is also `go fmt`'ing our files just prior to release. Signed-off-by: John Ryan <[email protected]>
pivotaljohn
pushed a commit
that referenced
this pull request
Oct 7, 2021
- this file was recently updated in a bug fix on parsing float values. as a result what _was_ a string is now a float literal (see #483) - `go fmt` uses lowercase 'e' for the exponent notation - various tooling applies `go fmt` to our code while building and releasing. - we've updated our build and test scripts to skip this package (see prior commits). - Go Releaser is also `go fmt`'ing our files just prior to release. Signed-off-by: John Ryan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regular expression is copy & pasted form the one in the spec.
The change suggested in go-yaml/yaml#171 and integrated was improper.
Closes go-yaml/yaml#290
(cherry-pick of go-yaml/yaml@7b8349a)
Signed-off-by: John Ryan [email protected]