Skip to content

Restrict dataVals vowel onset to times that can have formant values #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cwnaber wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Restrict dataVals vowel onset to times that can have formant values #165

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef83744
fix typo in variable name
cwnaber Jan 27, 2026
bf9589d
restrict onset index to within ftrack_taxis
cwnaber Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions speech/gen_dataVals_from_wave_viewer.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,10 +302,15 @@
onset_type = 'default amplitude onset';
end

% find boundaries for onset detection. Only consider samples that could
% have formants, ie, that exist in ftrack_taxis
startIx = find(sigmat.ampl_taxis > sigmat.ftrack_taxis(1), 1);
endIx = find(sigmat.ampl_taxis > sigmat.ftrack_taxis(end), 1) - 1; % subtracting 1 so endIx is inside the ftrack_taxis range

% find onset
onsetIndAmp = find(sigmat.ampl > ampl_thresh4voicing);
onsetIndAmp = find(sigmat.ampl(startIx:endIx) > ampl_thresh4voicing);
if onsetIndAmp
onsetIndAmp = onsetIndAmp(1) + 1;
onsetIndAmp = onsetIndAmp(1) + startIx;
else
onsetIndAmp = 1;
onset_type = 'no amplitude onset found';
Expand Down Expand Up @@ -341,7 +346,7 @@

% find the index of ftrack_taxis that's closest to and greater than ampl_taxis's onset index
[~, onsetIndFtrack] = find(sigmat.ftrack_taxis - sigmat.ampl_taxis(onsetIndAmp)>0, 1);
if ~isempty(onsetIndFrack)
if ~isempty(onsetIndFtrack)
offsetIndFtrack = find(ampl_Ftrack(onsetIndFtrack:end) < ampl_thresh4voicing);
else
offsetIndFtrack = [];
Expand Down