Notify if setting pitch tracking method for first time#159
Draft
Notify if setting pitch tracking method for first time#159
Conversation
Collaborator
Author
|
Current thought -- this is almost always notifying someone who doesn't care about pitch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In ~January 2024, I added functionality to wave_viewer to allow pitch tracking with Praat. Previously, a custom MATLAB script performed pitch tracking. Also in ~January 2024, a field was added to wave_viewer_params.mat to specify the pitch tracking method (sigproc_params.ptrack_method). The default pitch tracking method became 'praat'.
After that update, if a user loaded in a dataset where there was no value in sigproc_params.ptrack_method (ie, any dataset from before ~January 2024), ptrack_method would be automatically and silently set to 'praat'. If the user then recalculated that specific trial, or overwrote wave_viewer_params and then reran waverunner, the values and sampling rate of the pitch track would change. This could lead to situations where the pitch data changed unexpectedly.
This PR introduces a change that will announce to the user that the ptrack_method is being set to 'praat' and tells the user how to change it back, if they so desire. We expect that for most datasets, people are fine with using praat as the pitch tracking methods, if they are even concerned with the pitch tracking in the first place.