Skip to content

Use Bash for linux platforms#1189

Merged
carlrobertoh merged 1 commit intocarlrobertoh:masterfrom
gmaiorov:bash-linux
Feb 24, 2026
Merged

Use Bash for linux platforms#1189
carlrobertoh merged 1 commit intocarlrobertoh:masterfrom
gmaiorov:bash-linux

Conversation

@gmaiorov
Copy link
Copy Markdown
Contributor

Summary

Use Bash on linux-based OS to fix Bash-specific commands in BashTool.kt to resolve #1188.

Changes

Reworked buildShellCommand() function:

  • it uses when statement now to add some platform-related flexibility;
  • it uses bash on linux platforms;
  • it still uses sh on other non-windows platforms where bash may be missing by default.

@vercel
Copy link
Copy Markdown

vercel bot commented Feb 24, 2026

@gmaiorov is attempting to deploy a commit to the carlrobertohgmailcom's projects Team on Vercel.

A member of the Team first needs to authorize it.

@carlrobertoh
Copy link
Copy Markdown
Owner

Many thanks for your contribution!

Looks good, but I wonder if it's possible to use the Koog's in-built JvmShellCommandExecutor instead of relying on our own custom ProcessBuilder. They're practically doing the same thing.

@gmaiorov
Copy link
Copy Markdown
Contributor Author

Thanks for fast feedback!

While it seems that JvmShellCommandExecutor would address my usecase, I personally don't like hardcoding Bash for all platforms, and that would require some refactoring just for a sake of it.
And you're handling IO basically same, so I see no profit in that change.

@carlrobertoh carlrobertoh merged commit b501ffa into carlrobertoh:master Feb 24, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Using sh breaks shell execution

2 participants