Skip to content
This repository was archived by the owner on Jan 8, 2022. It is now read-only.

Cli ergonomics #9

Closed
gibix wants to merge 10 commits into from
Closed

Cli ergonomics #9

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
64c1bc8
Travis updates
gibix May 30, 2018
2ec7760
update copyright
gibix Jun 5, 2018
fac490a
Small code shake-up
gibix Jun 5, 2018
e7a61f8
Bump cargo version to 1.27
gibix Jun 5, 2018
d94ab48
Use structopt for argument parsing
gibix Jun 5, 2018
58c7335
Better error handling with failure::Error
gibix Jun 5, 2018
3596224
Handle --ebuild-path flag
gibix Jun 5, 2018
eb25067
Add basic logging with env_logger
gibix Jun 5, 2018
0ef37ce
Drop cargo for cargo_metadata
gibix Jun 5, 2018
96d7e97
Add first integration test
gibix Jun 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
sudo: false
language: rust
cache: cargo
dist: trusty
rust:
- nightly
Expand All @@ -9,6 +10,7 @@ rust:
matrix:
allow_failures:
- rust: nightly
- rust: 1.17.0
Copy link
Owner

@cardoe cardoe Jun 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see justification in the commit message why this should be allowed to fail. The commit message is not a place to state what has changed but a place to rationalize your changes. So why can it fail? I don't see anything in this commit that would lead me to believe WHY this should be allowed to fail. There are two realities:

  • in a later commit it starts failing because the minimum supported version needs to be changed so this change belongs in that commit
  • some other reason like one test fails intermittently with a later change and this change should be with that code change

Copy link
Contributor Author

@gibix gibix Jun 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, but I still not understand why 1.17.0 is there. I moved in allowed failures because there will never be chance for 1.17 to build.

before_script:
- |
pip install 'travis-cargo<0.2' --user &&
Expand Down
4 changes: 2 additions & 2 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ description = """
Generates an ebuild for a package using the in-tree eclasses.
"""

[badges]
travis-ci = { repository = "cardoe/cargo-ebuild" }
[badges.travis-ci]
repository = "cardoe/cargo-ebuild"
Copy link
Owner

@cardoe cardoe Jun 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the improvement here? I see the first form in most projects.

Copy link
Contributor Author

@gibix gibix Jun 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

personal porn-idiomatic


[dependencies]
cargo = "^0.21"
Expand Down