Concatenate multiple dataframes#98
Open
jihoonkang0829 wants to merge 2 commits intocardillo:masterfrom
Open
Conversation
I have found out that concat method already exists, thus I have mimicked pandas.concat to implement inner concat. The function is added as a method to DataFrame with docstring and tested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Per #83, I have mimicked the pandas.concat method to implement outer and inner concat for DataFrame, based on the pre-existing concat method in Combining class.
Why?
Enhancement for v1.1 milestone.
How?
Testing?
I have added tested both inner and outer concat.
Anything Else?
Performance of concat function can be further improved by improving the runtime of fillConcatDataFrame, such as by updating each combined column instead of by each index.