Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #51
To implement the feature, In DataFrame.java, I added overriding functions for writeCsv(...) with an additional parameter that specifies whether the user wants to add row names. In Serialization.java, I also included overriding functions and then in the main writeCvs(...) if the user wanted to write row names to the CSV, then the row name index is inserted into the first column of the data frame, which then is exported to a CSV. I also added two unit tests that test the new parameter (boolean writeRowNames) for when it is true and false. When it is false, I check to see if the row names column are not present in the csv file and the rest is the same. When it is true, I check to see if the row names column is present in the csv file and the rest is the same. My implementation passes these tests.