fix(react): remove default export from composed modal #11792
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abbeyhrt
changed the title
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
joshblack
approved these changes
Jul 13, 2022
kennylam
pushed a commit
to kennylam/carbon
that referenced
this pull request
Jul 30, 2024
…gn-system#11792) * fix(tearsheet): import modal and separate nested selectors * fix(tearsheet): codesandbox example * Update packages/carbon-web-components/examples/codesandbox/basic/components/tearsheet/index.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11590
When I refactored ComposedModal to a function, I accidentally left in the default export meaning that the class component is still what was being shipped (🤦♀️ ) This PR removes the default export and updates
src/index.jsso that the correct functional component is being exported.Testing / Reviewing
Verify that CI passes and ComposedModal functions as intended