bbr: Fix test flakes#578
Merged
Merged
Conversation
This fixes test flakes that happen due to timing of clock actions. The tests involve multiple goroutines that access the current time of the clock, but it may happen that an Advance() call in the test happens before a read of the clock time to create a new timer, thus causing a test flake. This issue is fixed by adding appropriate synchronization.
lthibault
approved these changes
Aug 6, 2024
lthibault
left a comment
lthibault
left a comment
Collaborator
There was a problem hiding this comment.
Great find. TY for the fix! This will be a crazy huge help when diving back into flow-control code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes test flakes that happen due to timing of clock actions.
The tests involve multiple goroutines that access the current time of the clock, but it may happen that an Advance() call in the test happens before a read of the clock time to create a new timer, thus causing a test flake.
This issue is fixed by adding appropriate synchronization.