Defend against nil-pointer panics in question.release#269
Merged
Conversation
zenhack
approved these changes
Jul 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was going to call this "Fix nil pointer panic due to nil question.release", but I'm not unsure whether this is what actually solved the problem I was experiencing in my application. However, my application was panicking due to a nil
question.releasefunction, so the proposed changes might still be reasonable defensive-programming measures.I grepped for
.release == nil, and there doesn't seem to be any code that depends on the nullability of this field, so I think this should be correct. A cross-check would be most welcome.