Fix broken implemenation of .Ack()#254
Merged
Merged
Conversation
The test currently deadlocks; the next commit will fix the issue.
Collaborator
|
Whoops -- just realized the tests are failing. Is this expected? |
Because the cancelCurrentCall channel has a fixed buffer size, if there is an ongoing call, then trying to insert into this will block, completely defeating .Ack(). This patch gets rid of the convoluted shutdown logic in favor of just constructing an appropriate context which is tied to both parent contexts. I'm not sure why I wrote it this way in the first place.
Contributor
Author
|
Fixed. |
lthibault
approved these changes
Jul 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I apparently completely broke this when I reworked the server internals to use an unbounded queue, as a result of some convoluted shutdown logic.
The first commit adds a test, verifying that calling Ack() does indeed unblock future calls. The test deadlocks.
The second commit fixes the test, by replacing said convoluted shutdown logic with a more straightforward implementation that works.