Fix compilation error and test on intel 32-bit#234
Merged
Conversation
zenhack
previously approved these changes
May 4, 2022
zenhack
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Bonus points if you want to add 386 to our CI, so it catches word size problems in the future.
Go test -race doesn't work on linux/386.
Contributor
Author
Good idea. Added 386 to the matrix and tested on a PR on my fork. |
Collaborator
|
@zenhack CI seems to be failing on the race condition we discovered a few days ago. I'm OK to merge this, since it's definitely not causing any new issues. |
Collaborator
|
P.S. @Matherunner : thank you very much for this fix! 🙂 |
zenhack
approved these changes
May 4, 2022
Contributor
|
Yeah, I agree; that's an existing failure and this doesn't touch anything but the tests so it's pretty low risk. Merging. Thanks @Matherunner! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the following.
Set
export GOARCH=386Then run
go test ./..., it will fail:After fixing the compilation error, this test will fail:
Anecdotally, the fixed version on a 32-bit Windows application runs fine when encoding, decoding, and doing basic RPC.