Fix issues that cause linters to complain.#182
Merged
Conversation
zenhack
approved these changes
Oct 28, 2021
| @@ -1,3 +1,4 @@ | |||
| //go:build !go1.5 | |||
Contributor
There was a problem hiding this comment.
This library can't possibly still work on Go 1.4, maybe we should just delete some of these? (can be a separate pr, if you want to take it on).
Collaborator
Author
There was a problem hiding this comment.
Yeah, let's def nuke it. So we should just drop these tags altogether?
zenhack
added a commit
to zenhack/go-capnp
that referenced
this pull request
Oct 28, 2021
Noticed when reviewing capnproto#182 that we don't currently test against the latest release, so let's do that.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
⏱️ Estimated review time: 10 minutes
✅ Merge when ready