Typed refcounting#163
Merged
Merged
Conversation
zombiezen
approved these changes
Feb 21, 2021
zombiezen
left a comment
zombiezen
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Please rebase and then I'll merge in.
I've found myself wanting these in the past (particularly AddRef());
otherwise it's very un-ergonomic to have to do Foo{ f.Client.AddRef() }
at every call site.
zenhack
force-pushed
the
typed-refcounting
branch
from
c38cb49 to
4747ab7
Compare
Contributor
Author
|
Done |
lthibault
pushed a commit
that referenced
this pull request
Feb 22, 2021
I've found myself wanting these in the past (particularly AddRef());
otherwise it's very un-ergonomic to have to do Foo{ f.Client.AddRef() }
at every call site.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've found myself wanting these in the past (particularly AddRef());
otherwise it's very un-ergonomic to have to do Foo{ f.Client.AddRef() }
at every call site.
Note that the first commit is from #162; this was the context in which I wanted those fixes. So you should probably review & merge that first.