sendCap: check for nil exports table/entries#113
Merged
Conversation
zombiezen
reviewed
Apr 3, 2018
zombiezen
left a comment
zombiezen
left a comment
Contributor
There was a problem hiding this comment.
LGTM. It would be nice to have a test for this, but all the ideas I have for triggering it would be pretty burdensome to ask you to write, so we can skip.
| // TODO(someday): Check for pipeline client on question for receiverAnswer. | ||
|
|
||
| // Default to sender-hosted (export). | ||
| if c.exports == nil { |
Contributor
There was a problem hiding this comment.
This isn't necessary, the for loop would just skip over it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #112
Note that I'm not terribly confident that this is the best thing to do; it seems like maybe exports should be initialized to an empty slice up front somwhere (doing it lazily here feels wrong) but I'm fuzzy on where that would be.