When examining annotations, check the value's tag.#109
Merged
Conversation
zombiezen
reviewed
Feb 26, 2018
zombiezen
left a comment
zombiezen
left a comment
Contributor
There was a problem hiding this comment.
Thanks for fixing this! One small change, if you don't mind.
| for i, n := 0, list.Len(); i < n; i++ { | ||
| a := list.At(i) | ||
| val, _ := a.Value() | ||
| if val.Which() != schema.Value_Which_text { |
Contributor
There was a problem hiding this comment.
Actually, it would be more correct to inline the val.Text() method call. $notag does not have a text value.
Otherwise, if we hit an annotation whose type is not Text, we'll panic. Fixes capnproto#107.
Contributor
Author
|
Quoting Ross Light (2018-02-26 10:27:55)
Thanks for fixing this! One small change, if you don't mind.
You're welcome, done.
|
zombiezen
approved these changes
Feb 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise, if we hit an annotation whose type is not Text, we'll panic.
Fixes #107.