Remove stale summary margin override from docs pages#16208
Open
kyungilcho wants to merge 1 commit intocanonical:mainfrom
Open
Remove stale summary margin override from docs pages#16208kyungilcho wants to merge 1 commit intocanonical:mainfrom
kyungilcho wants to merge 1 commit intocanonical:mainfrom
Conversation
|
kyungilcho is not a collaborator of the repo |
kyungilcho
requested a deployment
to
percy-testing
GitHub Actions
Waiting
kyungilcho
requested a deployment
to
percy-testing
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
summarymargin override fromstyles.scssWhy
The extra spacing on the livepatch docs
details/summaryelements was coming from a site-widesummary { margin: ... }rule that was originally added for an older download thank-you accordion. That markup no longer usesdetails/summary, so the global rule is now stale and leaks into docs pages that render raw HTML from Discourse.Testing
git diff --checkdocker build --target build-css -t ubuntu-com-build-css .Fixes #15905