Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR changes the GitHub Actions “Pack and Deploy” workflow trigger to run on pull requests to help QA charm/rock packing and deployment actions that were previously failing due to a dependency issue.
Changes:
- Switch workflow trigger from
pushonmaintopull_request. - Comment out the previous
pushtrigger configuration.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16191 +/- ##
==========================================
+ Coverage 48.14% 56.95% +8.81%
==========================================
Files 37 164 +127
Lines 5845 9514 +3669
Branches 0 1272 +1272
==========================================
+ Hits 2814 5419 +2605
- Misses 3031 4065 +1034
- Partials 0 30 +30 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done
This PR aims to QA the packing and deployment charm actions that were previously failing due to a dependency issue.
The fix has been upstreamed, more info in the ticket.
QA
pack-charmanddeploy-stagingactions passIssue / Card
Fixes WD-35541
Screenshots
[If relevant, please include a screenshot.]
Help
QA steps - Commit guidelines