Skip to content

qa: pack and deploy charm#16191

Open
britneywwc wants to merge 1 commit intocanonical:mainfrom
britneywwc:qa-charm-pack
Open

qa: pack and deploy charm#16191
britneywwc wants to merge 1 commit intocanonical:mainfrom
britneywwc:qa-charm-pack

Conversation

@britneywwc
Copy link
Copy Markdown
Contributor

@britneywwc britneywwc commented Mar 30, 2026

Done

This PR aims to QA the packing and deployment charm actions that were previously failing due to a dependency issue.
The fix has been upstreamed, more info in the ticket.

QA

  • Check that pack-charm and deploy-staging actions pass

Issue / Card

Fixes WD-35541

Screenshots

[If relevant, please include a screenshot.]

Help

QA steps - Commit guidelines

Copilot AI review requested due to automatic review settings March 30, 2026 08:23
@webteam-app
Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR changes the GitHub Actions “Pack and Deploy” workflow trigger to run on pull requests to help QA charm/rock packing and deployment actions that were previously failing due to a dependency issue.

Changes:

  • Switch workflow trigger from push on main to pull_request.
  • Comment out the previous push trigger configuration.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.95%. Comparing base (5afbbc9) to head (3f04a46).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16191      +/-   ##
==========================================
+ Coverage   48.14%   56.95%   +8.81%     
==========================================
  Files          37      164     +127     
  Lines        5845     9514    +3669     
  Branches        0     1272    +1272     
==========================================
+ Hits         2814     5419    +2605     
- Misses       3031     4065    +1034     
- Partials        0       30      +30     

see 127 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants