Skip to content

feat: bump katib-operators version 0.15.0 -> 0.16-rc.1 #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Aug 25, 2023
Merged

feat: bump katib-operators version 0.15.0 -> 0.16-rc.1 #123

merged 22 commits into from
Aug 25, 2023

Conversation

@orfeas-k
Copy link
Contributor

@orfeas-k orfeas-k commented Aug 22, 2023

This PR introduces the following changes:

  • Update template files to match 0.16-rc.1 release
  • Bump images to v0.16-rc.1 images

All updates were made using kubeflow/manifests#2506 as a reference.

Closes #122

Note to reviewer: Please make sure to check the relevant issue out and pay extra attention to points raised there, as some of these are changes I didn't feel extremely confident with.

@orfeas-k orfeas-k requested a review from a team as a code owner August 22, 2023 10:36
@github-actions github-actions bot added the Libraries: Out of sync The charm libs used are out-of-sync label Aug 22, 2023
@github-actions github-actions bot added Libraries: OK The charm libs used are OK and in-sync and removed Libraries: Out of sync The charm libs used are out-of-sync labels Aug 22, 2023
@i-chvets
Copy link
Contributor

i-chvets commented Aug 22, 2023

LGTM, other than suggestion for test improvement and failing CI. When resolved this PR will be ready to be approved.

@github-actions github-actions bot added Libraries: Out of sync The charm libs used are out-of-sync Libraries: OK The charm libs used are OK and in-sync and removed Libraries: OK The charm libs used are OK and in-sync Libraries: Out of sync The charm libs used are out-of-sync labels Aug 23, 2023
@github-actions github-actions bot added Libraries: Out of sync The charm libs used are out-of-sync Libraries: OK The charm libs used are OK and in-sync and removed Libraries: OK The charm libs used are OK and in-sync Libraries: Out of sync The charm libs used are out-of-sync labels Aug 23, 2023
@orfeas-k
Modify container's volumeConfig and args
7766d09 
Modify volumeConfig and container's args field (diverging from
upstream's manifests) in order to avoid following error that
katib-config.yaml is a directory.
@github-actions github-actions bot removed the Libraries: OK The charm libs used are OK and in-sync label Aug 24, 2023
@github-actions github-actions bot added Libraries: OK The charm libs used are OK and in-sync Libraries: Out of sync The charm libs used are out-of-sync and removed Libraries: Out of sync The charm libs used are out-of-sync Libraries: OK The charm libs used are OK and in-sync labels Aug 25, 2023
@github-actions github-actions bot added Libraries: OK The charm libs used are OK and in-sync Libraries: Out of sync The charm libs used are out-of-sync and removed Libraries: Out of sync The charm libs used are out-of-sync Libraries: OK The charm libs used are OK and in-sync labels Aug 25, 2023
@github-actions github-actions bot added Libraries: OK The charm libs used are OK and in-sync Libraries: Out of sync The charm libs used are out-of-sync and removed Libraries: Out of sync The charm libs used are out-of-sync Libraries: OK The charm libs used are OK and in-sync labels Aug 25, 2023
@github-actions github-actions bot added Libraries: OK The charm libs used are OK and in-sync Libraries: Out of sync The charm libs used are out-of-sync and removed Libraries: Out of sync The charm libs used are out-of-sync Libraries: OK The charm libs used are OK and in-sync labels Aug 25, 2023
i-chvets
i-chvets reviewed Aug 25, 2023
View reviewed changes
@orfeas-k
Revert "add -vv"
96d7bbd 
This reverts commit 9950e24.
@github-actions github-actions bot added Libraries: OK The charm libs used are OK and in-sync and removed Libraries: Out of sync The charm libs used are out-of-sync labels Aug 25, 2023
@orfeas-k orfeas-k enabled auto-merge (squash) August 25, 2023 14:14
@i-chvets
Copy link
Contributor

i-chvets commented Aug 25, 2023

Verified integratoin tests locally. LGTM.

i-chvets
i-chvets approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@i-chvets i-chvets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All comments resolved. Approved.

@orfeas-k orfeas-k merged commit b00817e into main Aug 25, 2023
@orfeas-k orfeas-k deleted the kf-4178-update-katib-for-1.8-release branch August 25, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@i-chvets i-chvets i-chvets approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Libraries: OK The charm libs used are OK and in-sync

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bump katib-operators version 0.15.0 -> 0.16-rc.1 for release 1.8

3 participants

@orfeas-k @i-chvets