Skip to content

[v3] TrackChoiceManager keeps the last reference in case of several being communicated #1680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2025
Merged

[v3] TrackChoiceManager keeps the last reference in case of several being communicated #1680

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/core/api/tracks_management/track_choice_manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,6 +263,7 @@ export default class TrackChoiceManager {
period: Period,
adaptationRef: SharedReference<Adaptation | null | undefined>,
): void {
log.debug("TCM: Adding Track Reference", bufferType, period.id);
const periodItem = getPeriodItem(this._periods, period);
const adaptations = period.getSupportedAdaptations(bufferType);
if (periodItem !== undefined) {
Expand All @@ -271,7 +272,7 @@ export default class TrackChoiceManager {
`TrackChoiceManager: ${bufferType} already added for period`,
period.start,
);
return;
periodItem[bufferType]?.adaptationRef.finish();
} else {
periodItem[bufferType] = { adaptations, adaptationRef };
}
Expand All @@ -287,6 +288,7 @@ export default class TrackChoiceManager {
* @param {Period} period - The concerned Period.
*/
public removePeriod(bufferType: "audio" | "text" | "video", period: Period): void {
log.debug("TCM: Removing Track Reference", bufferType, period.id);
const periodIndex = findPeriodIndex(this._periods, period);
if (periodIndex === undefined) {
log.warn(`TrackChoiceManager: ${bufferType} not found for period`, period.start);
Expand All @@ -312,6 +314,7 @@ export default class TrackChoiceManager {
}

public resetPeriods(): void {
log.debug("TCM: Resetting Period Objects");
while (this._periods.length() > 0) {
this._periods.pop();
}
Expand Down
Loading